Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UT for deploy.go #3332

Closed
wants to merge 1 commit into from

Conversation

realnumber666
Copy link
Contributor

@realnumber666 realnumber666 commented Mar 26, 2023

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Promote UT coverage
Which issue(s) this PR fixes:
Part of #3327

Special notes for your reviewer:
Still work in process, please ignore it.

Does this PR introduce a user-facing change?:
NONE

@karmada-bot karmada-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 26, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign prodanlabs after the PR has been reviewed.
You can assign the PR to them by writing /assign @prodanlabs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2023

Codecov Report

Merging #3332 (b7f4f8c) into master (1d030d4) will increase coverage by 0.12%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3332      +/-   ##
==========================================
+ Coverage   51.32%   51.45%   +0.12%     
==========================================
  Files         209      209              
  Lines       18757    18757              
==========================================
+ Hits         9627     9651      +24     
+ Misses       8632     8589      -43     
- Partials      498      517      +19     
Flag Coverage Δ
unittests 51.45% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: rayywu <rayywu@tencent.com>
@realnumber666 realnumber666 changed the title [WIP] Add UT for deploy.go Add UT for deploy.go Mar 31, 2023
@realnumber666 realnumber666 reopened this Mar 31, 2023
@XiShanYongYe-Chang
Copy link
Member

/reopen

@karmada-bot
Copy link
Collaborator

@XiShanYongYe-Chang: Failed to re-open PR: state cannot be changed. There is already an open pull request from realnumber666:add-unit-test to karmada-io:master.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants