-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UT for deploy.go #3332
Add UT for deploy.go #3332
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #3332 +/- ##
==========================================
+ Coverage 51.32% 51.45% +0.12%
==========================================
Files 209 209
Lines 18757 18757
==========================================
+ Hits 9627 9651 +24
+ Misses 8632 8589 -43
- Partials 498 517 +19
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: rayywu <rayywu@tencent.com>
a3dfc45
to
b7f4f8c
Compare
/reopen |
@XiShanYongYe-Chang: Failed to re-open PR: state cannot be changed. There is already an open pull request from realnumber666:add-unit-test to karmada-io:master. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Promote UT coverage
Which issue(s) this PR fixes:
Part of #3327
Special notes for your reviewer:
Still work in process, please ignore it.
Does this PR introduce a user-facing change?:
NONE